May 2023 Pre-Release

.eslintrc.json

@@ -20,7 +20,8 @@
  "plugin:react/recommended",
  "plugin:react-hooks/recommended",
  "plugin:security/recommended",
- "plugin:import/typescript"
+ "plugin:import/typescript",
+ "prettier"
  ],
  "rules": {
  "@angular-eslint/component-class-suffix": 2,
@@ -45,7 +46,6 @@
  "@typescript-eslint/camelcase": 0,
  "@typescript-eslint/explicit-member-accessibility": 0,
  "@typescript-eslint/explicit-module-boundary-types": 2,
- "@typescript-eslint/indent": [2, 4, { "SwitchCase": 1 }],
  "@typescript-eslint/interface-name-prefix": 0,
  "@typescript-eslint/member-delimiter-style": 0,
  "@typescript-eslint/no-angle-bracket-type-assertion": 0,
@@ -56,8 +56,6 @@
  "@typescript-eslint/no-object-literal-type-assertion": 0,
  "@typescript-eslint/no-unused-vars": 2,
  "@typescript-eslint/prefer-interface": 0,
- "@typescript-eslint/semi": 2,
- "@typescript-eslint/type-annotation-spacing": 0,
  "eol-last": 2,
  "eqeqeq": 2,
  "header/header": [2, "block", [ "", " * Copyright (c) Microsoft Corporation. All rights reserved.", " * Licensed under the MIT License.", " " ], 2],
@@ -75,7 +73,6 @@
  "no-param-reassign": 2,
  "no-var": 2,
  "prefer-const": 2,
- "quotes": [2, "double"],
  "react/jsx-closing-bracket-location": 2,
  "react/jsx-closing-tag-location": 2,
  "react/jsx-curly-spacing": [2, {"when": "never", "attributes": {"allowMultiline": false }, "children": true}],
@@ -96,6 +93,9 @@
  "settings": {
  "react": {
  "version": "17.0.0"
+ },
+ "import/resolver": {
+ "typescript": {} // this loads <rootdir>/tsconfig.json to eslint
  }
  }
 }

.github/labeler.yml

@@ -16,8 +16,6 @@ msal-browser:
  - lib/msal-browser/**/*
 msal-react:
  - lib/msal-react/**/*
-node-token-validation:
- - lib/node-token-validation/**/*
 adal.js:
  - maintenance/adal-angular/**/*
 passport-azure-ad:

.github/workflows/beachball-bump.yml

@@ -56,7 +56,7 @@ jobs:
  # Create/update Pull Request
  - name: Create Pull Request
  id: pr
- uses: peter-evans/create-pull-request@v4
+ uses: peter-evans/create-pull-request@v5
  with:
  commit-message: Bump package versions
  branch: release-staging

.github/workflows/build-test-merge-group.yml

@@ -1,7 +1,7 @@
 # This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
 # For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
 
-name: Dev branch CI 
+name: Dev branch CI
 # Runs CI on all libraries when a PR is merged
 
 on:
@@ -22,17 +22,16 @@ jobs:
  strategy:
  fail-fast: false
  matrix:
- library: 
+ library:
  - msal-core
  - msal-common
  - msal-browser
  - msal-node
  - msal-angular
  - msal-react
- - node-token-validation
 
  name: ${{ matrix.library }}
- 
+
  steps:
  - uses: actions/checkout@v3
 
@@ -68,12 +67,12 @@ jobs:
  with:
  files: lib/${{matrix.library}}/coverage/lcov.info
  flags: ${{ matrix.library }}
- 
+
  extensions-build-test:
  runs-on: windows-2019
- 
+
  name: msal-node-extensions
- 
+
  steps:
  - uses: actions/checkout@v3
 
@@ -102,4 +101,4 @@ jobs:
  uses: codecov/codecov-action@v3
  with:
  files: extensions/msal-node-extensions/coverage/lcov.info
- flags: msal-node-extensions
+ flags: msal-node-extensions

.github/workflows/build-test-pr.yml

@@ -11,7 +11,7 @@ on:
  - 'extensions/msal-node-extensions/**/*'
  - '!**.md'
  - '.github/workflows/build-test-pr.yml'
- 
+
 concurrency:
  group: ci-${{github.ref}}
  cancel-in-progress: true
@@ -25,7 +25,7 @@ jobs:
  contents: read # for dorny/paths-filter to fetch a list of changed files
  pull-requests: read # for dorny/paths-filter to read pull requests
  runs-on: ubuntu-latest
- outputs: 
+ outputs:
  # Expose matched filters as job 'packages' output variable
  packages: ${{ steps.lib-filter.outputs.changes }}
  extensions: ${{ steps.extensions-filter.outputs.node-extensions }}
@@ -57,9 +57,6 @@ jobs:
  msal-react:
  - *browser
  - 'lib/msal-react/**/**.!(md)'
- node-token-validation:
- - *common
- - 'lib/node-token-validation/**/**.!(md)'
 
  - uses: dorny/paths-filter@v2
  id: extensions-filter
@@ -80,9 +77,9 @@ jobs:
  # Parse JSON array containing names of all filters matching any of changed files
  # e.g. ['package1', 'package2'] if both package folders contains changes
  library: ${{ fromJSON(needs.pre-check.outputs.packages) }}
- 
+
  name: ${{ matrix.library }}
- 
+
  steps:
  - uses: actions/checkout@v3
 
@@ -137,9 +134,9 @@ jobs:
  needs: pre-check
  runs-on: windows-2019
  if: needs.pre-check.outputs.extensions == 'true'
- 
+
  name: msal-node-extensions
- 
+
  steps:
  - uses: actions/checkout@v3
 

.github/workflows/msal-angular-e2e.yml

@@ -11,7 +11,7 @@ on:
  - 'lib/msal-angular/**/*'
  - 'lib/msal-browser/**/*'
  - 'lib/msal-common/**/*'
- - 'samples/msal-angular-v2-samples/**/*'
+ - 'samples/msal-angular-v3-samples/**/*'
  - 'samples/e2eTestUtils/**/*'
  - 'samples/package-lock.json'
  - '!**.md'
@@ -35,15 +35,7 @@ jobs:
  fail-fast: false
  matrix:
  sample:
- - 'angular9-v2-sample-app'
- - 'angular10-sample-app'
- - 'angular11-sample-app'
- - 'angular12-sample-app'
- - 'angular13-rxjs6-sample-app'
- - 'angular13-rxjs7-sample-app'
- - 'angular14-rxjs6-sample-app'
- - 'angular14-rxjs7-sample-app'
- - 'angular-b2c-sample-app'
+ - 'angular15-sample-app'
 
  name: ${{ matrix.sample }}
 
@@ -69,17 +61,17 @@ jobs:
  run: npm ci
 
  - name: Install ${{ matrix.sample }}
- working-directory: samples/msal-angular-v2-samples/${{ matrix.sample }}
+ working-directory: samples/msal-angular-v3-samples/${{ matrix.sample }}
  run: |
  npm run install:local
  npm install
 
  - name: Build ${{ matrix.sample }}
- working-directory: samples/msal-angular-v2-samples/${{ matrix.sample }}
+ working-directory: samples/msal-angular-v3-samples/${{ matrix.sample }}
  run: npm run build
 
  - name: E2E Tests
- working-directory: samples/msal-angular-v2-samples/${{ matrix.sample }}
+ working-directory: samples/msal-angular-v3-samples/${{ matrix.sample }}
  timeout-minutes: 5
  env:
  AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}

.github/workflows/msal-browser-e2e.yml

@@ -47,6 +47,8 @@ jobs:
 
  - name: Use Node.js
  uses: actions/setup-node@v3
+ with:
+ node-version: 16
 
  - name: Restore node_modules for libs
  uses: actions/cache@v3

.github/workflows/msal-core-e2e.yml

@@ -33,6 +33,8 @@ jobs:
 
  - name: Use Node.js
  uses: actions/setup-node@v3
+ with:
+ node-version: 16
 
  - name: Restore node_modules for libs
  uses: actions/cache@v3