Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jest to v29 and Puppeteer to v20 #5980

Merged
merged 44 commits into from
May 31, 2023
Merged

Update Jest to v29 and Puppeteer to v20 #5980

merged 44 commits into from
May 31, 2023

Conversation

jo-arroyo
Copy link
Collaborator

@jo-arroyo jo-arroyo commented May 4, 2023

Updating Jest to v29 and Puppeteer to v20. This enables Angular 16 compatibility and brings our sample tests up to date.

Note: Updating Puppeteer to use Chrome headless 'new' will come at a later date.

@github-actions github-actions bot added the samples Related to the samples apps for the library. label May 4, 2023
constructor(config) {
super(config);
}
constructor({ globalConfig, projectConfig }, context) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jo-arroyo jo-arroyo marked this pull request as ready for review May 19, 2023 18:51
@jo-arroyo jo-arroyo changed the title Update Jest to v29 Update Jest to v29 and Puppeteer to v20 May 19, 2023
@ghost
Copy link

ghost commented May 29, 2023

Reminder: The next release is scheduled for next week and this PR appears to be stale :(

If changes have been requested please address feedback.
If this PR is still a work in progress please mark as draft.

@ghost ghost added the Needs: Attention 👋 Awaiting response from the MSAL.js team label May 29, 2023
@ghost ghost removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label May 30, 2023
@jo-arroyo jo-arroyo enabled auto-merge (squash) May 31, 2023 11:54
@jo-arroyo jo-arroyo merged commit 047e788 into dev May 31, 2023
46 checks passed
@jo-arroyo jo-arroyo deleted the upgrade-jest-29 branch May 31, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants