Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update maintained node versions to fix tsdx optional chaining #6014

Merged
merged 3 commits into from
May 12, 2023
Merged

Update maintained node versions to fix tsdx optional chaining #6014

merged 3 commits into from
May 12, 2023

Conversation

konstantin-msft
Copy link
Collaborator

@konstantin-msft konstantin-msft commented May 12, 2023 •
edited
Loading

  • Update maintained node versions to fix tsdx optional chaining.
  • Address Guardian pipeline errors.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (msal-lts@9c8c39b). Click here to learn what that means.
The diff coverage is n/a.

Flag Coverage Δ
msal-node 80.68% <0.00%> (?)

@github-actions github-actions bot added documentation Related to documentation. msal@1.x Related to msal@1.x (implicit flow) labels May 12, 2023
@konstantin-msft konstantin-msft marked this pull request as ready for review May 12, 2023 18:22
@konstantin-msft konstantin-msft merged commit 6c0501a into msal-lts May 12, 2023
@konstantin-msft konstantin-msft deleted the fix_lts_node branch May 12, 2023 18:54
@ghost
Copy link

ghost commented Jun 7, 2023

🎉@azure/msal-node@v1.17.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@lalimasharda lalimasharda lalimasharda approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@jennyf19 jennyf19 Awaiting requested review from jennyf19 jennyf19 is a code owner

@jmprieur jmprieur Awaiting requested review from jmprieur jmprieur is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS bgavrilMS is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

Assignees
No one assigned
Labels
documentation Related to documentation. msal@1.x Related to msal@1.x (implicit flow)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@konstantin-msft @codecov-commenter @tnorling @lalimasharda