Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address semver CVE-2022-25883 and other moderate severity vulnerabilities #6259

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Address semver CVE-2022-25883 and other moderate severity vulnerabilities #6259

merged 6 commits into from
Jul 24, 2023

Conversation

konstantin-msft
Copy link
Collaborator

@konstantin-msft konstantin-msft commented Jul 24, 2023 •
edited
Loading

  • Address semver CVE-2022-25883 and other moderate severity vulnerabilities.
  • Pin lerna to v6 for msal-node-e2e.yml.

@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package samples Related to the samples apps for the library. msal@1.x Related to msal@1.x (implicit flow) msal-node Related to msal-node package msal-browser Related to msal-browser package msal-common Related to msal-common package msal-react Related to @azure/msal-react extensions Related to extensions for the base libraries node-token-validation labels Jul 24, 2023
@konstantin-msft konstantin-msft marked this pull request as ready for review July 24, 2023 13:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (msal-lts@ac6a41f). Click here to learn what that means.
The diff coverage is n/a.

Flag Coverage Δ
msal-angular 96.63% <0.00%> (?)
msal-browser 86.17% <0.00%> (?)
msal-common 84.32% <0.00%> (?)
msal-node 80.68% <0.00%> (?)
msal-node-extensions 73.50% <0.00%> (?)
msal-react 94.68% <0.00%> (?)
node-token-validation 88.46% <0.00%> (?)

@github-actions github-actions bot removed msal@1.x Related to msal@1.x (implicit flow) msal-node Related to msal-node package labels Jul 24, 2023
@github-actions github-actions bot added the msal-node Related to msal-node package label Jul 24, 2023
@konstantin-msft konstantin-msft force-pushed the fix_semver_cve branch 2 times, most recently from acb735b to dd43ec2 Compare July 24, 2023 20:48
hectormmg
hectormmg approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@hectormmg hectormmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of the security upgrades!

@konstantin-msft konstantin-msft merged commit a7e37cd into msal-lts Jul 24, 2023
48 of 49 checks passed
@konstantin-msft konstantin-msft deleted the fix_semver_cve branch July 24, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectormmg hectormmg hectormmg approved these changes

@tnorling tnorling tnorling approved these changes

@peterzenz peterzenz peterzenz approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@jennyf19 jennyf19 Awaiting requested review from jennyf19 jennyf19 is a code owner

@jmprieur jmprieur Awaiting requested review from jmprieur jmprieur is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS bgavrilMS is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@lalimasharda lalimasharda Awaiting requested review from lalimasharda lalimasharda is a code owner

Assignees
No one assigned
Labels
extensions Related to extensions for the base libraries msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package msal-react Related to @azure/msal-react node-token-validation samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@konstantin-msft @codecov-commenter @hectormmg @tnorling @peterzenz