Added msal-node client-credential regression test #6276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbie-Microsoft
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz,
jo-arroyo,
lalimasharda,
bgavrilMS and
konstantin-msft
as code owners
12 tasks
pmaytak
reviewed
Aug 5, 2023
pmaytak
reviewed
Aug 5, 2023
pmaytak
reviewed
Aug 5, 2023
bgavrilMS
approved these changes
Aug 23, 2023
tnorling
reviewed
Aug 25, 2023
| "author": "", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "@azure/msal-node": "^1.18.0", |
There was a problem hiding this comment.
We should probably include this in workspaces so you pull the local versions of msal-node (and also remove package-lock)
Robbie-Microsoft
requested review from
trwalke,
gladjohn,
neha-bhargava,
rayluo and
Avery-Dunn
as code owners
trwalke
approved these changes
Aug 30, 2023
pmaytak
approved these changes
Sep 6, 2023
trwalke
approved these changes
Sep 6, 2023
trwalke
reviewed
Sep 6, 2023
| clientId: "client_id", | ||
| authority: "https://login.microsoftonline.com/tenant_id", | ||
| knownAuthorities: ["https://login.microsoftonline.com/tenant_id"], | ||
| clientSecret: "client_secret", |
There was a problem hiding this comment.
nit: should probably also do one for certificates. maybe in another PR.
rayluo
reviewed
Sep 9, 2023
| name: msal-node client-credential Regression Test | ||
| tool: 'benchmarkjs' | ||
| output-file-path: regression-tests/msal-node/client-credential/output.txt | ||
| external-data-json-path: ./cache/client-credential-benchmark-data.json |
There was a problem hiding this comment.
FWIW, although this external-data-json-path and the actions/cache@v3 above were mentioned in Continuous Benchmark's README, its actual github workflow yml file did not need to use such an external data file. I ended up not using this setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the beginnings of regression testing for msal-node confidential client flows; In this specific case, the client credential flow. BenchmarkJS is used to measure performance of msal-node.
Sample output of BenchmarkJS looks like:
If a regression of >10% is detected, github actions will leave a commit comment:
Example of commit comment when a fake regression was introduced to this PR.
Every time a PR is merged into dev, the latest output from "regression-tests/msal-node/client-credential/output.txt" (if available, if the client-credential test was run on the PR) will be saved to the branch "gh-pages", and will be available to visually see at: https://azuread.github.io/microsoft-authentication-library-for-js/dev/bench/.