Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for esm imports #7142

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

JeroenBoesten
Copy link

This PR fixes some import issues in the builded .d.ts files because we were getting the following error on a couple of files.

 error TS2835: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you 
mean '../config/Configuration.mjs'?

2 import { ManagedIdentityConfiguration } from "../config/Configuration";

The lack of the for esm required suffixes made it impossible to compile, if you look at some other files like PublicClientApplication those already contains the correct suffixes so this PR just fixes some of the imports that were missing this and should not break any backwards compatibility.

@JeroenBoesten
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Contributor

Reminder: This PR appears to be stale. If this PR is still a work in progress please mark as draft.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-node Related to msal-node package Needs: Attention 👋 Awaiting response from the MSAL.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant