Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SNI certs #7188

Merged
merged 14 commits into from
Jul 9, 2024
Merged

Use SNI certs #7188

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9fb624e
Use SNI certs
hectormmg Jul 3, 2024
652edc8
Merge branch 'dev' into sni-cert
hectormmg Jul 3, 2024
e23ff47
Update Azure SDK Identity
hectormmg Jul 8, 2024
c75c358
Add script to re-order x5c chain to put left cert first
hectormmg Jul 8, 2024
bd92ba2
Merge branch 'sni-cert' of https://github.com/AzureAD/microsoft-authe…
hectormmg Jul 8, 2024
abc6f60
Temporarily set branch to sni-cert for pipelines
hectormmg Jul 8, 2024
055546f
Merge branch 'dev' into sni-cert
hectormmg Jul 9, 2024
21b1e25
Refactor updatePemCert.js
hectormmg Jul 9, 2024
afa7f9a
Fix typo
hectormmg Jul 9, 2024
ded7fc8
Add debugging statement
hectormmg Jul 9, 2024
6073c6d
Remove console logs
hectormmg Jul 9, 2024
06ac02b
Update package-lock
hectormmg Jul 9, 2024
2cb9660
Update package-lock
hectormmg Jul 9, 2024
26a9c57
Revert branch reference change
hectormmg Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gen_env.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ $clientIdValue = $(az keyvault secret show --name "LabVaultAppId" --vault-name "
$pfxPath = "LabCert.pfx";
$pemPath = "LabCert.pem";
# get the lab app cert
az keyvault secret download --vault-name "msidlabs" -n "LabVaultAccessCert" --file $pfxPath --encoding base64
az keyvault secret download --vault-name "msidlabs" -n "LabAuth" --file $pfxPath --encoding base64
# convert pfx file to pem
openssl pkcs12 -in $pfxPath -out $pemPath -nodes --passin pass:

Expand Down
5 changes: 4 additions & 1 deletion samples/e2eTestUtils/src/LabClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ export class LabClient {
this.credentials = new ClientCertificateCredential(
tenant,
clientId,
client_cert_path
client_cert_path,
{
sendCertificateChain: true,
}
);
}

Expand Down
Loading