Added Docker client invocation builder; ability to form pipes (resolves #1) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| A builder (https://en.wikipedia.org/wiki/Builder_pattern) for Popen objects representing a | ||
| Docker client invocation. When building a Popen object, it distinguishes between three | ||
| layers, the `popen` layer, the `docker` layer and the `extra` layer. The `popen` layer |
There was a problem hiding this comment.
I don't like extra as a layer name, because it is never referred to as such in Docker docs. Leaving that off is perhaps not clear enough?
(Docker()
.docker_command('run') # invoke `docker run`
.docker_params('ubuntu', interactive=True) # pass `--interactive` and run `ubuntu` image
.docker_params(rm=True) # docker() is cumulative, also pass `--rm`
.command('foo') # invoke `foo` command inside container
.params('/', bar=42) # pass `--bar=42 /` to foo
.popen_params(cwd='/foo/bar') # pass `cwd='/foo/bar'` to the Popen constructor
.work_dir('/foo/bar') # same
.build_popen_call())There was a problem hiding this comment.
I agree extra is bad and I like just leaving it off. So
extra_command => command
extra_params =>params
but there also the extra(command,*args,**opts) shortcut. What do we name that?
hannes-ucsc
force-pushed
the
issues/1-rewrite-docker-call
branch
from
3d975e8 to
5b504ac
Compare
- revised handling of boolean options (foo=False removes previous occurrences of --foo rather than add --foo=false) - s/extra/container - added keyword args to magic __ methods - added documentation - disallow multiple docker command - make docker_command and container_command not cumulative
|
@heuermh, I looked at all docker command |
|
Yes, I like |
glennhickey
pushed a commit
to glennhickey/toil-lib
that referenced
this pull request
Jan 30, 2017
…nstallable Added toil dependency to setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1