modifications to support megabeast simulations #821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The megabeast simulations are based on recomputing the prior weights using the megabeast ensemble model. This requires computing the prior weights on the full sedgrid at once. In the beast, the stellar priors are computed on the spectral grid (not sed grid) and this allows for some simplifications. Code to address computing the stellar priors on the spectral or sed grid is added. In addition, the dust priors are moved to a function so that the same function can be used in the beast and megabeast.
As part of this work, a new check is added to determine if there are repeat masses in the single age isochrone. This is the easiest way to tell if stellar prior and grid weights are being computed on the spec or sed grids (spec has no dust and is where it is done for the BEAST). Surprisingly, there is at least one case where there is a repeated mass in the spec grid - e.g., directly computed from the stellar isochrones. Thus, the new code produces slightly different results than the previous code as now the repeated masses get the correct grid weight whereas before they were not.
In addition, a bug in
make_ast_input_list.py
was found on line 188 when regenerating the regression test files. There must have been an upstream behavior that allowed this line to work. It logically should not have worked. @drvdputt: any insights on this? This was your code from a few years back. No worries if it doesn't spark anything. Just being comprehensive and tagging you.