Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/195] 리뷰 수정 api 로직 오류 해결 #196

Merged
merged 1 commit into from
Mar 6, 2024
+7 −30
Merged

[Feature/195] 리뷰 수정 api 로직 오류 해결 #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 7 additions & 30 deletions src/main/java/com/example/betteriter/fo_domain/review/service/ReviewService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,9 +424,8 @@ public void updateReview(Long reviewId, UpdateReviewRequestDto request) {
this.updateReviewImages(review, request.getImageList());

// 3. 리뷰 스펙 데이터 업데이트
List<ReviewSpecData> nowReviewSpecDataList = reviewSpecDataRepository.findAllByReview(review);
List<SpecData> newSpecDataList = this.specConnector.findAllSpecDataByIds(request.getSpecData());
this.updateReviewSpecData(review, nowReviewSpecDataList, newSpecDataList);
this.updateReviewSpecData(review, newSpecDataList);

reviewRepository.save(review);

Expand Down Expand Up @@ -466,36 +465,14 @@ private void updateReviewImages(Review review, List<String> imageList) {
}
}

private void updateReviewSpecData(Review review, List<ReviewSpecData> nowReviewSpecDataList,
List<SpecData> newSpecDataList) {
/*
* 1. nowReviewSpecDataList 와 newReviewSpecDataList 를 비교하여 변경된 데이터가 있는지 확인
* 1-1. SpecData 의 specId 가 같으며 SpecData 의 id 가 다르다면 변경된 데이터로 판단
* 1-2. SpecData 의 specId 가 존제하지 않았으면 추가된 데이터로 판단
* 2. 변경된 데이터가 있다면 변경된 데이터를 업데이트
* 2-1. (1-1) 에서 변경된 데이터가 있다면 같은 specId 를 가진 데이터를 update
* 2-2. (1-2) 에서 추가된 데이터가 있다면 추가된 데이터를 insert
*/
private void updateReviewSpecData(Review review, List<SpecData> newSpecDataList) {
List<ReviewSpecData> nowReviewSpecDataList = review.getSpecData();
reviewSpecDataRepository.deleteAll(nowReviewSpecDataList);

log.info("nowReviewSpecDataList : {}", nowReviewSpecDataList);
log.info("newReviewSpecDataList : {}", newSpecDataList);

List<SpecData> nowSpecDataList = nowReviewSpecDataList.stream()
.map(ReviewSpecData::getSpecData)
List<ReviewSpecData> newReviewSpecDataList = newSpecDataList.stream()
.map(specData -> ReviewSpecData.createReviewSpecData(review, specData))
.collect(Collectors.toList());

newSpecDataList.forEach(newSpecData -> {
if (isChanged(newSpecData, nowSpecDataList)) {
ReviewSpecData nowReviewSpecData = nowReviewSpecDataList.stream()
.filter(nowData -> isSameSpecId(nowData, newSpecData))
.findFirst()
.orElseThrow(() -> new ReviewHandler(_REVIEW_SPEC_DATA_NOT_FOUND));

nowReviewSpecData.updateSpecData(newSpecData);
} else if (isAdded(newSpecData, nowReviewSpecDataList)) {
reviewSpecDataRepository.save(ReviewSpecData.createReviewSpecData(review, newSpecData));
}
});
reviewSpecDataRepository.saveAll(newReviewSpecDataList);
}

private boolean isChanged(SpecData newSpecData, List<SpecData> nowSpecDataList) {
Expand Down
Loading