Implement constant-time hash ordering #420
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements constant-time ordering (and partial ordering) for
Hash
, but does so differently than #267 and #370.It uses
subtle
internally to lexicographically compare corresponding bytes, being careful not to short circuit. This simplifies the logic considerably.Note that it does not use
subtle
to implementPartialEq
; this functionality exists in #419 since it seemed better scoped for a separate PR. However, if #419 is implemented, it will be possible to implementConstantTimeGreater
andConstantTimeLess
due to the latter requiring aConstantTimeEq
trait bound included in that PR.