Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-tidy, x86 dll #20

Merged
merged 19 commits into from
Feb 25, 2024
Merged

Conversation

cen1
Copy link
Contributor

@cen1 cen1 commented Feb 25, 2024

  • adds x86 dll build to release CI
  • change to __cdecl dll export to stay compatible with existing bot binaries (this was broken since initial github code import apparently!)
  • fixes some CMake issues I missed in previous patches
  • adds a workaround for a gmp x86 build bug
  • adds .clang-tidy with first enabling most useful rules, then disabling the ones which require more heavy handed edits
  • fix some clang-tidy warnings. For now only did the ones I am 99% confident don't break any code and disabled the rest. There are 100+ more warnings to fix but I need to brush up on my modern c++ skills and add some unit tests so we are more confident we are not breaking functionality.
  • add .clang-format sample, should be applied as a separate patch to not mix fixes with formatting changes

Overall I am happy with this and a release can be tagged. I'll get back to work with point 6 in a more distant future.

Please squash on merge because there are a bunch of trial and error commits in this series.

@carlbennett carlbennett merged commit 5571561 into BNETDocs:master Feb 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants