Ignore ModuleMissing* validation if Id is not correct

BUTR · Nov 14, 2024 · c9f98e9 · c9f98e9
1 parent 485a6ec
commit c9f98e9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Bannerlord.ModuleManager/ModuleUtilities.cs b/src/Bannerlord.ModuleManager/ModuleUtilities.cs
@@ -419,6 +419,9 @@ private static IEnumerable<ModuleIssueV2> ValidateModuleDependenciesEx(
         // Check that all dependencies are present
         foreach (var metadata in targetModule.DependenciesToLoadDistinct())
         {
+            // Ignore the check if the Id is incorrect
+            if (string.IsNullOrWhiteSpace(metadata.Id)) continue;
+
             // Ignore the check for Optional
             if (metadata.IsOptional) continue;
 
@@ -597,7 +600,8 @@ public static IEnumerable<ModuleIssueV2> ValidateLoadOrderEx(
 
             if (metadataIdx == -1)
             {
-                if (!metadata.IsOptional)
+                // If the dependency lacks an Id, it's not valid
+                if (!string.IsNullOrWhiteSpace(metadata.Id) && !metadata.IsOptional)
                 {
                     if (metadata.Version != ApplicationVersion.Empty)
                         yield return new ModuleMissingExactVersionDependencyIssue(targetModule, metadata);