Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle allocation #539

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fix handle allocation #539

merged 1 commit into from
Dec 12, 2023

Conversation

cwfitzgerald
Copy link
Member

Checklist

  • CI Checked:
    • cargo fmt has been ran
    • [x]cargo clippy reports no issues
    • cargo test succeeds
    • cargo rend3-doc has no warnings
    • cargo deny check issues have been fixed or added to deny.toml
  • Manually Checked:
    • relevant examples/test cases run
    • changes added to changelog
      • Add credit to yourself for each change: Added new functionality @githubname.

Related Issues

#533

Description

We were allocating handles before validating the resources given to us. This caused a drop instruction to get added even though an add instruction never happened.

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) December 12, 2023 02:53
@cwfitzgerald cwfitzgerald merged commit 9065f1e into trunk Dec 12, 2023
6 checks passed
@John-Nagle
Copy link
Contributor

This is working. When I run an overly large scene, there is no crash, rendering of previously loaded content works fine, and new mesh creation attempts return the error ExceededMaximumBufferSize Thanks. I can work with this.

Now I have level-of-detail work to do on my side, to take appropriate action when full.

@cwfitzgerald cwfitzgerald deleted the fix-handle-allocation branch December 12, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants