-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wgpu
dependency to 0.19.0.
#567
Conversation
Incorporated updating |
It occurs to me that there's a subtlety here — with |
This should be ready to merge, in principle. Tests don't pass locally, though:
I'm not sure what's up with that, but it seems to be a preexisting issue. |
You need |
Then the testing steps in |
* Updates `wgpu-profiler` to match. * Updates `naga` too to satisfy cargo-deny. * `rend3_gltf::util::format_components()` is now implemented by calling `TextureFormat::components()`, which seems to be the same function.
Updated |
@cwfitzgerald The mac CI failure has no details — failure to start perhaps? In any case, what does this PR need to move forward? |
Yeah I pulled my local runner for security concerns - let's merge this and I'll fix it in a follow up. |
Checklist
cargo fmt
has been rancargo clippy
reports no issuescargo test
succeedscargo rend3-doc
has no warningscargo deny check
issues have been fixed or added to deny.tomlAdded new functionality @githubname
.Description
Updates
wgpu
to the new release 0.19.0.wgpu-profiler
to match.rend3_gltf::util::format_components()
is now implemented by callingwgpu::TextureFormat::components()
, which seems to be the same function.