Skip to content

Commit

Permalink
Update Babylon.js and Babylon Native to the latest (#67)
Browse files Browse the repository at this point in the history
* Update PackageTest for @babylon/react-native base-64 dependency

Update proguard-rules.pro for Hermes

Update README.md to reflect Hermes support

* Update Babylon.js and Babylon Native to the latest
  • Loading branch information
ryantrem authored Aug 7, 2020
1 parent 6ba5397 commit af5d41d
Show file tree
Hide file tree
Showing 9 changed files with 36 additions and 21 deletions.
2 changes: 2 additions & 0 deletions Apps/PackageTest/android/app/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@
# http://developer.android.com/guide/developing/tools/proguard.html

# Add any project specific keep options here:
-keep class com.facebook.hermes.unicode.** { *; }
-keep class com.facebook.jni.** { *; }
16 changes: 12 additions & 4 deletions Apps/PackageTest/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Apps/PackageTest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lint": "eslint . --ext .js,.jsx,.ts,.tsx"
},
"dependencies": {
"@babylonjs/core": "4.2.0-alpha.30",
"@babylonjs/core": "4.2.0-alpha.31",
"@babylonjs/react-native": "file:../../Package/Assembled/babylonjs-react-native-0.0.1.tgz",
"react": "16.13.1",
"react-native": "0.63.1",
Expand Down
2 changes: 2 additions & 0 deletions Apps/Playground/android/app/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@
# http://developer.android.com/guide/developing/tools/proguard.html

# Add any project specific keep options here:
-keep class com.facebook.hermes.unicode.** { *; }
-keep class com.facebook.jni.** { *; }
22 changes: 11 additions & 11 deletions Apps/Playground/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Apps/Playground/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"lint": "eslint . --ext .js,.jsx,.ts,.tsx"
},
"dependencies": {
"@babylonjs/core": "4.2.0-alpha.30",
"@babylonjs/loaders": "4.2.0-alpha.30",
"@babylonjs/core": "4.2.0-alpha.31",
"@babylonjs/loaders": "4.2.0-alpha.31",
"@babylonjs/react-native": "file:../../Modules/@babylonjs/react-native",
"@react-native-community/slider": "^2.0.9",
"logkitty": "^0.7.1",
Expand Down
2 changes: 1 addition & 1 deletion Modules/@babylonjs/react-native/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"base-64": "^0.1.0"
},
"peerDependencies": {
"@babylonjs/core": "^4.2.0-alpha.30",
"@babylonjs/core": "^4.2.0-alpha.31",
"react": "^16.13.1",
"react-native": "^0.63.1",
"react-native-permissions": "^2.1.4"
Expand Down
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ This project provides Babylon Native integration into React Native.
Babylon React Native is in the early phase of its development, and has the following limitations:

1. Android and iOS support only - support for Windows is planned, but the timeline is currently unknown.
1. JavaScriptCore (JSC) only - the published @babylonjs/react-native package is configured specifically for JSC, though it is possible to rebuild it and target other JavaScript engines supported by React Native. In the future, the published package will directly support all JavaScript engines that can be used with React Native.
1. Touch input only - mouse, keyboard, and controllers are not yet supported.
1. Single view only - multiple views are not yet supported (only a single view can be displayed).

It is also worth noting that Babylon React Native relies heavily on newer React Native constructs including JSI to get the performance characteristics required for real time rendering. JSI allows for direct synchronous communication between native code and JavaScript code, but is incompatible with "remote debugging." If you need to debug your JavaScript code that uses Babylon React Native, you should enable Hermes and use "direct debugging" (e.g. chrome://inspect or edge://inspect). See the [React Native documentation](https://reactnative.dev/docs/hermes) for more info.

## Usage

Expand Down

0 comments on commit af5d41d

Please sign in to comment.