-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpcount command #210
gpcount command #210
Conversation
Sorry the review took so long to do. I only saw the PR just now. Also, please test with the gpsize or size command. Please test how this affects race edits (eg race order, score edits, changing place, etc) for races that "fall off" the end of the table when gp size is changed to 2 gps with 12 races played, and those edits occurred on Race 9-12. TIA and thanks for the contribution! |
That should fix the issues. Let me know if there are more. I noticed the /gpsize slash command didn't work, so I fixed it as well. If running I tried Another comment, I got this stack trace if trying to run after install:
|
I agree that's how it should work. I think doing the other way would actually introduce a lot of bugs. Noted on the Pillow. I believe I ran into the issue myself and forgot to update the requirements.txt. PR looks good. Thanks for testing. Will merge in now and go live in a few minutes. |
If you want to type up an announcement of how to use the command, I will post in Table Bot server. |
Thanks for merging. Maybe something like:
Feel free to edit. |
Description
Adds a gpcount command, which allows a user to change the number of gps after a war has been started. Have tested with offline testing rooms, but not on live rooms from Wiimmfi.
Checklist