Skip to content

Commit

Permalink
Merge pull request #18 from BardoQi/analysis-vQR5PE
Browse files Browse the repository at this point in the history
Apply fixes from StyleCI
  • Loading branch information
BardoQi authored Oct 8, 2020
2 parents cd0ecc0 + 1c5e7b5 commit f9ecdfa
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions tests/Unit/ExceptionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public function testExceptions()
$users = $users->fromLocal($user_array);

try {
$users = $users->outerJoinForeign($albums_array, 'albums','');
$users = $users->outerJoinForeign($albums_array, 'albums', '');
} catch (\Exception $e) {
$this->assertTrue($e instanceof InvalidArgumentException);
}
Expand Down Expand Up @@ -164,6 +164,5 @@ public function testExceptions()
} catch (\Exception $e) {
$this->assertTrue($e instanceof InvalidArgumentException);
}

}
}
4 changes: 2 additions & 2 deletions tests/Unit/HasManyTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public function testPresenterJoin()
$user_ids = $blog->pluck('created_by');
//You can check the $user_ids result with:
// print_r($user_ids);
$blog = $blog->innerJoinForeign($user_array, 'user','id')
$blog = $blog->innerJoinForeign($user_array, 'user', 'id')
->onRelation('created_by', 'user', 'id');

$image_array_string = include dirname(dirname(__DIR__)).'/tests/Fixture/Images.php';
Expand All @@ -50,7 +50,7 @@ public function testPresenterJoin()
// print_r($image_ids);
$image_array = json_decode($image_array_string, true);

$blog = $blog->outerJoinForeign($image_array, 'image','id')
$blog = $blog->outerJoinForeign($image_array, 'image', 'id')
->onRelationbyObject(
Relation::of($blog->local_alias, 'images', 'image', 'id', RelationEnum::HAS_MANY_SPLIT)
);
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/HasOneTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function testPresenterJoin()
$image_array_string = include dirname(dirname(__DIR__)).'/tests/Fixture/Images.php';
$image_array = json_decode($image_array_string, true);

$users = $users->innerJoinForeign($image_array, 'images','id')
$users = $users->innerJoinForeign($image_array, 'images', 'id')
->onRelation('avatar_id', 'images', 'id')
->toArray();

Expand Down

0 comments on commit f9ecdfa

Please sign in to comment.