Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: button habilitation on bal card #949

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

fufeck
Copy link
Contributor

@fufeck fufeck commented Aug 20, 2024

CONTEXT

Les communes ne comprennent pas tjs qu'il faut cliquer sur gérer les adresses lorsque la BAL est en attente d'habilitation

FONCTIONNALITE

  • Ajout d'un bouton habiliter la BALsur la card qui redirige sur la page /bal
  • Sur la page /bal, ouvre automatiquement la popup d'habilitation si le status est en waiting habilitation

RESULTAT

Capture d’écran 2024-08-20 à 16 25 34

@fufeck fufeck requested a review from MaGOs92 August 20, 2024 14:29
@fufeck fufeck force-pushed the fufeck_feat_button-habilitation-on-bal-card branch from 28640d5 to 7928fba Compare August 20, 2024 14:31
@fufeck fufeck force-pushed the fufeck_feat_button-habilitation-on-bal-card branch from 48eb1d2 to 1a211da Compare September 4, 2024 10:11
Copy link
Contributor

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM
Tests : Je vois bien le bouton "Habiliter la BAL", par contre quand je cliques dessus la pop-up ne s'ouvre pas.
https://www.loom.com/share/08610cb89398489393e73871e28db9c2

@fufeck
Copy link
Contributor Author

fufeck commented Sep 9, 2024

Code LGTM Tests : Je vois bien le bouton "Habiliter la BAL", par contre quand je cliques dessus la pop-up ne s'ouvre pas. https://www.loom.com/share/08610cb89398489393e73871e28db9c2

Ca marche bien de mon coté et quand je regarde le code, ca me parait bon.
As tu trafiqué ta DB pour que cela soit en waiting habilitation ? As tu oublié d'expirer l'habilitation ou de mettre le status = published ou sync.status = outdated ?

Capture d’écran 2024-09-09 à 10 25 59

@fufeck fufeck requested a review from MaGOs92 September 9, 2024 08:29
@fufeck fufeck force-pushed the fufeck_feat_button-habilitation-on-bal-card branch from 1f931ff to 4c92467 Compare September 11, 2024 12:26
Copy link
Contributor

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes nickel après le clean de la db tout fonctionne bien. Il devait y avoir un truc qui clochait avec la BAL que j'ai utilisé pour tester

@fufeck fufeck merged commit 2b6a3f3 into master Sep 18, 2024
6 checks passed
@fufeck fufeck deleted the fufeck_feat_button-habilitation-on-bal-card branch October 14, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants