Bump undici and @sveltejs/kit #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [undici](https://github.com/nodejs/undici) to 5.26.5 and updates ancestor dependency [@sveltejs/kit](https://github.com/sveltejs/kit/tree/HEAD/packages/kit). These dependencies need to be updated together. Updates `undici` from 5.22.1 to 5.26.5 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.22.1...v5.26.5) Updates `@sveltejs/kit` from 1.21.0 to 1.30.3 - [Release notes](https://github.com/sveltejs/kit/releases) - [Changelog](https://github.com/sveltejs/kit/blob/main/packages/kit/CHANGELOG.md) - [Commits](https://github.com/sveltejs/kit/commits/@sveltejs/kit@1.30.3/packages/kit) --- updated-dependencies: - dependency-name: undici dependency-type: indirect - dependency-name: "@sveltejs/kit" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
bvanvugt
approved these changes
Jan 20, 2024
bvanvugt
deleted the
dependabot/npm_and_yarn/undici-and-sveltejs/kit-5.26.5
branch
coreyja
added a commit
that referenced
this pull request
Jan 20, 2024
Builds are currently failing with this error message Accessing url.searchParams during prerendering is forbidden. If you need to use it, ensure you are only doing so in the browser (for example in onMount). It was introduced in #79 This error is because we are trying to access url.searchParams in the load function and ALSO have preloading enabled. Since load gets called on the server to pre-render, it doesn't allow us to access url.searchParams since that can only be known in the browser But this must be new behavior, since it was working for us previously. I think it was working previously is because load was acting as a 'universal` loader and running both in the 'server' when preloading, and also in the client when mounting for the first time. kit.svelte.dev/docs/load#universal-vs-server-when-does-which-load-function-run I imagine the server load was getting an empty searchSet, but continuing to work. And then the client load correctly filled in the query param values But from reading the Changelog I can't find anything that seems obviously like it would have broken this behavior I do think this is a good change to prepare for v2, since it seems required there as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps undici to 5.26.5 and updates ancestor dependency @sveltejs/kit. These dependencies need to be updated together.
Updates
undicifrom 5.22.1 to 5.26.5Release notes
Sourced from undici's releases.
... (truncated)
Commits
9197790Bumped v5.26.5c31bd88Update namespace type with Fetch exports (#2361)24db5d4Remove a couple of unnecessary async functions (#2367)63afd9bDrop race condition in connect-timeout test (#2360)dea70e2Bumped v5.26.40681760fix names with esbuild (#2359)daf349ffix: Avoid error for stream() being aborted (#2355)49254c3Update DispatchInterceptor.md (#2354)52a7989test: only include WebSocket in WPT Report where it's landed (#2351)40ab050test: first attempt for flaky fix (#2337)Updates
@sveltejs/kitfrom 1.21.0 to 1.30.3Release notes
Sourced from
@sveltejs/kit's releases.... (truncated)
Changelog
Sourced from
@sveltejs/kit's changelog.... (truncated)
Commits
9ae5943Version Packages (#11302)f82df6cfix: correct documentation forbeforeNavigate(#11300)99e4bfbVersion Packages (#11296)86a1357fix: revert recent error changes (#11295)b2b1951Version Packages (#11288)5b81a21fix: action not found should return 404 (#11278)5b1d1abfix: prevent incorrect trailing slash redirect for prerendered root page when...f7b4f18Version Packages (#11275)594568efeat: inline Response.arrayBuffer inside load functions during ssr (#10535)d7ba3bffix: call workerunrefinstead ofterminate(#10120)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.