Play: Add option to write NDJSON "replay file". #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to record the WS frames as they're sent and replay them later with the Board server.
Schoonology
requested review from
robbles,
bvanvugt and
chris-bsnake
as code owners
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
playcommand, you can now use--replay PATHto specify where to write a playback-optimized Newline-Delimited JSON file. These files can then be read by the board server.The responsibilities were split in this way to allow the Board server to be long-running, and for the Rules CLI to write new files ad hoc.
The board PR has specific feedback requests, in particular for file formatting and extension.l