Closes #3709: reshape to return a multi-dimensional array #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
force-pushed
the
3709-reshape-to-return-a-multi-dimensional-array
branch
from
f60286d
to
48d1530
Compare
Co-authored-by: drculhane <drculhane@users.noreply.github.com>
ajpotts
force-pushed
the
3709-reshape-to-return-a-multi-dimensional-array
branch
from
0a2fd0f
to
12f9d21
Compare
ajpotts
requested review from
jeremiah-corrado,
stress-tess,
drculhane and
jaketrookman
jeremiah-corrado
approved these changes
Aug 29, 2024
This was referenced Sep 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the reshape function to return a multi-dimensional
pdarrayrather thanArrayView.Also strips out the
ArrayViewclass and module.Closes #3709: reshape to return a multi-dimensional array
Co-authored with @drculhane .