-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Blocks and Items Sections to v1.21.40 #928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a fan of the title of the page/file name. How about rendering-blocks-as-items
? Sure it's longer but it's descriptive and you can tell what the page will be about based on just the URL and title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving the block an icon was an example, the page serves to explain what a block item is and gives a way to modify their components. Maybe examples with different components could be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such as using tags for recipes, fuel, and mob heads? More examples would be great, but Block Items isn't really descriptive. overriding-blocks-itemstack
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Block Items is descriptive for a page about the item types related to blocks, it's also the phrase Mojang uses to refer to them (block item config, replace_block_item
).
Given that the page isn't purely focused on replacing block items, I think it would be wrong to name the entire page around that concept. We can still link to that part in a way that is readable from the URL block-items#replacing-block-items
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only descriptive since we both know what Block Items are from Java's source code and what Mojang calls them. I think blocks-itemstack
might be more descriptive personally.
Blocks
minecraft:redstone_conductivity
component.Items
minecraft:durability_sensor
component.minecraft:damage_absorption
component.minecraft:dyeable
component.minecraft:rarity
component.minecraft:storage_item
component.minecraft:bundle_interaction
component.