Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beam datum updates, assembly code refactor, adds the ability to place assemblies on tanks #11046

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Beam datum updates, assembly code refactor, adds the ability to place assemblies on tanks #11046

wants to merge 13 commits into from

Conversation

XeonMations
Copy link
Contributor

@XeonMations XeonMations commented Jun 4, 2024 •
edited
Loading

About The Pull Request

Refactored the Beam datum to be in line with TG's, update assembly code, add the ability to place assemblies on reagent dispensers and have them properly work.

TG station PR that this PR ported code changes from:

Why It's Good For The Game

Updated code good, also helps have less of a buggy mess with our assemblies.

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 SyncIt21, 13spacemen, SuperSayu, ZephyrTFA, MrMelbert, TiviPlus, AnturK, LemonInTheDark, Kylerace, Ghilker, Fikou, Ben10Omintrix, Ghommie, ShizCalev, SyncIt21, Timberpoes, stylemistake, MacBlaze1, robbertapir, timothymtorres, haukeschuemann, JohnFulpWillard, XeonMations
refactor: Updated assembly code to be more in line with TG"s
refactor: Updated beam datum code to be more in line with TG"s as well
fix: Fixed infrared sensors creating two beams when thrown diagonally
add: Added the ability to place assemblies on welding tanks
/:cl:

@XeonMations
Attempt 1
40eb67f 
To do: Fix the infrared laser's source position not updating when placed on a table

make the infrared laser emissive

fix the error
@XeonMations
bug fix
a73112d
@XeonMations
to do: fix signaller send button
5cb2d2b
@XeonMations
fixes
afc7016
@XeonMations XeonMations changed the title Beam datum changes, refactor assemblies, add the ability to place Beam datum updates, assembly code refactor, adds the ability to place assemblies on tanks Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 label Jun 7, 2024
@XeonMations XeonMations marked this pull request as ready for review June 9, 2024 16:46
PowerfulBacon
PowerfulBacon reviewed Jul 14, 2024
View reviewed changes
code/datums/beam.dm Outdated Show resolved Hide resolved
code/datums/beam.dm Outdated Show resolved Hide resolved
code/game/communications.dm Outdated Show resolved Hide resolved
code/game/communications.dm Outdated Show resolved Hide resolved
code/modules/assembly/assembly.dm Outdated Show resolved Hide resolved
code/modules/assembly/assembly.dm Outdated Show resolved Hide resolved
code/modules/assembly/health.dm Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PowerfulBacon PowerfulBacon Awaiting requested review from PowerfulBacon

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Administration Code Improvement Feature Fix Refactor TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XeonMations @PowerfulBacon