Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Goonstation improvements(?) #1

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

pali6
Copy link

@pali6 pali6 commented May 18, 2023

Based on discussion in the OpenDream Discord here the changes from our fork. Accompanied by Crossedfall/crossed-cogs#23

  • Support for arbitrary versions.
  • Normalization of indentation so you can use e.g. two spaces.
  • Cleanup of the output.
  • Multiple Docker paths are tried on Linux

Let me know if any of this sucks or you don't want it and I'll remove it from the PR.

compile.sh Outdated Show resolved Hide resolved
listener.py Outdated Show resolved Hide resolved
listener.py Show resolved Hide resolved
@pali6
Copy link
Author

pali6 commented May 18, 2023

I was bypassing Dockerfile because just passing the relevant arguments to run was the first solution I found back when I was doing this a couple of years ago. Now it should be done more correctly (I hope) by building the beestation/byond image and then building the test image from the Dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants