use ament export targets #778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove legacy ament functions * Add ament_export_targets * Match namespace for conan and ROS * Depends on ament/ament_cmake#498 merging and backport to humble * Add CI for export tests and colcon building Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
|
Red CI.... |
Yes, Ill get it green after If you want some of the CI stuff merged in a separate MR that can go in now, I'm happy split it up. |
|
closing this, unti it passes CI checks |
|
Do you have ability to re-run CI on this? It should work now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upgrade the support to latest ament recommendations, which uses CMake targets.
Addtions
I added a CI task to check it works. The stuff in
exportfolder is merely to check the installation of BTCPP is correct.Ticket
Closes #751
CI status
CI will be red until the next
humblesync.