support unlisted video url format #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, happy to include it but some tests are failing - please can you review |
|
Sorry for the delay - missed a major regression as it didn't apply to the specific use case I needed to support. Fixed the regression and added a couple additional test urls for the unlisted url format. |
|
Sorry but it looks like it's still failing |
|
I should probably figure out how to extend the tests to test for the optional hash on the Vimeo urls, but this is now passing. Thanks for pushing me on a crash course in running unit tests. |
|
Thanks for persevering and getting it to pass. I've merged it in and released it under v2.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR for #16