Allow patching undeclared methods; emit warning instead

BepInEx · Nov 8, 2020 · 9a08670 · 9a08670
1 parent 0e6860c
commit 9a08670
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/Harmony/Public/PatchProcessor.cs b/Harmony/Public/PatchProcessor.cs
@@ -6,6 +6,7 @@
 using System.Reflection.Emit;
 using HarmonyLib.Internal.Patching;
 using HarmonyLib.Public.Patching;
+using HarmonyLib.Tools;
 
 namespace HarmonyLib
 {
@@ -130,10 +131,7 @@ public MethodInfo Patch()
 				throw new NullReferenceException($"Null method for {instance.Id}");
 
 			if (original.IsDeclaredMember() is false)
-			{
-				var declaredMember = original.GetDeclaredMember();
-				throw new ArgumentException($"You can only patch implemented methods/constructors. Path the declared method {declaredMember.FullDescription()} instead.");
-			}
+				Logger.Log(Logger.LogChannel.Warn, () => $"{instance.Id}: You should only patch implemented methods/constructors to avoid issues. Path the declared method {original.GetDeclaredMember().FullDescription()} instead of {original.FullDescription()}.");
 
 			lock (locker)
 			{