Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add awaiter implementation #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

extraes
Copy link

@extraes extraes commented Jun 17, 2024

Adds Pass61ImplementAwaiters
Looks for types implementing INotifyCompletion and generates new methods that allow the interop types to implement that interface, calling the Il2CppSystem.Action -> System.Action implicit conversion before calling the original method.

This makes originally-awaitable types (e.g. UniTasks, if the game has them) awaitable again.

I previously did this in a much less automated way with Cecil in another project, but the runtime didn't like what I was doing, so I figured I'd make it less janky and add it to Il2CppInterop, and sure enough the runtime no longer rejects the type.

@ds5678 ds5678 added generation Related to assembly generation enhancement New feature or request labels Jul 15, 2024
@ds5678
Copy link
Collaborator

ds5678 commented Jul 15, 2024

This seems like it will be fixed automatically by my planned type system improvements. I am hesitant to merge this special case pull request when a generic fix is planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request generation Related to assembly generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants