Skip to content

Commit

Permalink
Fix #1581: Star rating doesn't update in File pane without Select/Sho…
Browse files Browse the repository at this point in the history
…w Marks

#1581

Make view-file respond to changes in metadata when star rating is
displayed
  • Loading branch information
caclark committed Dec 30, 2024
1 parent f351de8 commit 1b67431
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/view-file/view-file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1827,6 +1827,10 @@ void vf_notify_cb(FileData *fd, NotifyType type, gpointer data)
gboolean refresh;

auto interested = static_cast<NotifyType>(NOTIFY_CHANGE | NOTIFY_REREAD | NOTIFY_GROUPING);
if (options->show_star_rating)
{
interested = static_cast<NotifyType>(interested | NOTIFY_METADATA);
}
if (vf->marks_enabled) interested = static_cast<NotifyType>(interested | NOTIFY_MARKS | NOTIFY_METADATA);
/** @FIXME NOTIFY_METADATA should be checked by the keyword-to-mark functions and converted to NOTIFY_MARKS only if there was a change */

Expand Down

0 comments on commit 1b67431

Please sign in to comment.