Bug fix: System icons are not shown in AppImages

- LinuxDeploy gtk plugin was missing - An explicit load of librsvg is required for the minimal AppImages
BestImageViewer · Dec 27, 2024 · ff74099 · ff74099
1 parent eba438f
commit ff74099
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/.github/workflows/appimage-aarch64.yml b/.github/workflows/appimage-aarch64.yml
@@ -63,10 +63,13 @@ jobs:
             wget https://github.com/linuxdeploy/linuxdeploy/releases/download/continuous/linuxdeploy-aarch64.AppImage \
               -O tools/linuxdeploy-aarch64.AppImage
             chmod +x tools/linuxdeploy-aarch64.AppImage
+            wget https://raw.githubusercontent.com/linuxdeploy/linuxdeploy-plugin-gtk/master/linuxdeploy-plugin-gtk.sh
+            chmod +x linuxdeploy-plugin-gtk.sh
             tools/linuxdeploy-aarch64.AppImage \
               --desktop-file $GITHUB_WORKSPACE/AppDir/usr/share/applications/org.geeqie.Geeqie.desktop \
               --icon-file $GITHUB_WORKSPACE/AppDir/usr/share/pixmaps/geeqie.png \
               --appdir $GITHUB_WORKSPACE/AppDir \
+              --plugin gtk \
               --output appimage
             mv Geeqie-aarch64.AppImage Geeqie-latest-aarch64.AppImage
 

diff --git a/.github/workflows/appimage-minimal-aarch64.yml b/.github/workflows/appimage-minimal-aarch64.yml
@@ -26,6 +26,7 @@ jobs:
             yes | sudo apt-get install git
             yes | sudo apt-get install libgtk-3-bin
             yes | sudo apt-get install libgtk-3-dev
+            yes | sudo apt-get install librsvg2-dev
             yes | sudo apt-get install meson
             yes | sudo apt-get install ninja-build
             yes | sudo apt-get install pandoc
@@ -67,10 +68,13 @@ jobs:
             wget https://github.com/linuxdeploy/linuxdeploy/releases/download/continuous/linuxdeploy-aarch64.AppImage \
               -O tools/linuxdeploy-aarch64.AppImage
             chmod +x tools/linuxdeploy-aarch64.AppImage
+            wget https://raw.githubusercontent.com/linuxdeploy/linuxdeploy-plugin-gtk/master/linuxdeploy-plugin-gtk.sh
+            chmod +x linuxdeploy-plugin-gtk.sh
             tools/linuxdeploy-aarch64.AppImage \
               --desktop-file $GITHUB_WORKSPACE/AppDir/usr/share/applications/org.geeqie.Geeqie.desktop \
               --icon-file $GITHUB_WORKSPACE/AppDir/usr/share/pixmaps/geeqie.png \
               --appdir $GITHUB_WORKSPACE/AppDir \
+              --plugin gtk \
               --output appimage
             mv Geeqie-aarch64.AppImage Geeqie-minimal-latest-aarch64.AppImage
 

diff --git a/.github/workflows/appimage-minimal-x86_64.yml b/.github/workflows/appimage-minimal-x86_64.yml
@@ -15,6 +15,7 @@ jobs:
           sudo apt install -y gettext
           sudo apt install -y libgtk-3-bin
           sudo apt install -y libgtk-3-dev
+          sudo apt install -y librsvg2-dev
           sudo apt install -y pandoc
           sudo apt install -y patchelf
           sudo apt install -y wget
@@ -78,11 +79,14 @@ jobs:
         run: |
           wget https://github.com/linuxdeploy/linuxdeploy/releases/download/continuous/linuxdeploy-x86_64.AppImage
           chmod +x linuxdeploy-x86_64.AppImage
+          wget https://raw.githubusercontent.com/linuxdeploy/linuxdeploy-plugin-gtk/master/linuxdeploy-plugin-gtk.sh
+          chmod +x linuxdeploy-plugin-gtk.sh
 
       - name: Build AppImage
         run: |
           ./linuxdeploy-x86_64.AppImage --appdir ${{ github.workspace }}/AppDir \
             --desktop-file ${{ github.workspace }}/AppDir/usr/share/applications/org.geeqie.Geeqie.desktop \
+            --plugin gtk \
             --output appimage
           mv Geeqie-x86_64.AppImage Geeqie-minimal-latest-x86_64.AppImage
 

diff --git a/.github/workflows/appimage-x86_64.yml b/.github/workflows/appimage-x86_64.yml
@@ -75,11 +75,14 @@ jobs:
         run: |
           wget https://github.com/linuxdeploy/linuxdeploy/releases/download/continuous/linuxdeploy-x86_64.AppImage
           chmod +x linuxdeploy-x86_64.AppImage
+          wget https://raw.githubusercontent.com/linuxdeploy/linuxdeploy-plugin-gtk/master/linuxdeploy-plugin-gtk.sh
+          chmod +x linuxdeploy-plugin-gtk.sh
 
       - name: Build AppImage
         run: |
           ./linuxdeploy-x86_64.AppImage --appdir ${{ github.workspace }}/AppDir \
             --desktop-file ${{ github.workspace }}/AppDir/usr/share/applications/org.geeqie.Geeqie.desktop \
+            --plugin gtk \
             --output appimage
           mv Geeqie-x86_64.AppImage Geeqie-latest-x86_64.AppImage