Skip to content

Commit

Permalink
feat: disable factory bot association cop by default (#49)
Browse files Browse the repository at this point in the history
**Summary of changes**:
Per a conversation in Slack we don't seem to have strong opinions about
this, so disabling this cop here for all our projects using Betterlint.
  • Loading branch information
andimrob authored Jul 10, 2024
1 parent 048be08 commit 26f17e2
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 13 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
betterlint (1.12.0)
betterlint (1.13.0)
rubocop (~> 1.62.0)
rubocop-graphql (~> 1.5.0)
rubocop-performance (~> 1.21.0)
Expand Down
2 changes: 1 addition & 1 deletion betterlint.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)

Gem::Specification.new do |s|
s.name = "betterlint"
s.version = "1.12.0"
s.version = "1.13.0"
s.authors = ["Development"]
s.email = ["development@betterment.com"]
s.summary = "Betterment rubocop configuration"
Expand Down
25 changes: 14 additions & 11 deletions config/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,18 @@ Betterment/NonStandardActions:
- update
StyleGuide: '#bettermentnonstandardactions'

Betterment/RedirectStatus:
SafeAutoCorrect: false
Description: Detect missing status codes when redirecting POST, PUT, PATCH, or DELETE responses
Include:
- app/controllers/**/*.rb

Betterment/RenderStatus:
SafeAutoCorrect: false
Description: Detect missing status codes when rendering POST, PUT, PATCH, or DELETE responses
Include:
- app/controllers/**/*.rb

Betterment/ServerErrorAssertion:
Description: Detects assertions on 5XX HTTP statuses.
Include:
Expand All @@ -77,17 +89,8 @@ Betterment/UnsafeJob:
Betterment/UnscopedFind:
StyleGuide: '#bettermentunscopedfind'

Betterment/RedirectStatus:
SafeAutoCorrect: false
Description: Detect missing status codes when redirecting POST, PUT, PATCH, or DELETE responses
Include:
- app/controllers/**/*.rb

Betterment/RenderStatus:
SafeAutoCorrect: false
Description: Detect missing status codes when rendering POST, PUT, PATCH, or DELETE responses
Include:
- app/controllers/**/*.rb
FactoryBot/AssociationStyle:
Enabled: false

FactoryBot/ConsistentParenthesesStyle:
Enabled: false
Expand Down

0 comments on commit 26f17e2

Please sign in to comment.