Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Style/FrozenStringLiteralComment cop to be enabled #28

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

dkubb
Copy link
Contributor

@dkubb dkubb commented Nov 3, 2023

Summary

This branch changes rubocop to ensure there is a frozen literal string comment at the top of every ruby file.

dkubb added 2 commits November 3, 2023 14:41
* Use `rubocop --autocorrect-all` to add the frozen string literal directive
  to the top of every ruby file.
@dkubb dkubb marked this pull request as ready for review November 3, 2023 21:46
Copy link
Contributor

@willlockwood willlockwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool looks good—just gonna take platform here since it feels like a good idea to have multiple people sign off on enabling this by default 👍🏻

platform lgtm

cc @smudge @effron @Betterment/ruby-platform-reviewers for domain

Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM

@dkubb
Copy link
Contributor Author

dkubb commented Nov 14, 2023

Thanks for the approvals! I don't have permission to merge this one.

If @smudge or @willlockwood have permission, and you feel comfortable with the change, please be my guest.

@smudge smudge merged commit 0a5d24a into Betterment:main Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants