Add lockfile #32
Add lockfile #32
Conversation
Irving-Betterment
force-pushed
the
icaro/lockfiles_commit
branch
2 times, most recently
from
24ffa5a to
97e5bde
Compare
Irving-Betterment
force-pushed
the
icaro/lockfiles_commit
branch
6 times, most recently
from
9c16b46 to
26b4274
Compare
Irving-Betterment
force-pushed
the
icaro/lockfiles_commit
branch
from
26b4274 to
9e4efb5
Compare
Irving-Betterment
force-pushed
the
icaro/lockfiles_commit
branch
from
9e4efb5 to
38d6ffc
Compare
Irving-Betterment
force-pushed
the
icaro/lockfiles_commit
branch
from
520f833 to
9beeec5
Compare
| @@ -4,7 +4,6 @@ | |||
| .DS_Store | |||
| .rvmrc | |||
| /coverage | |||
| Gemfile.lock | |||
| gemfiles/*.lock | |||
There was a problem hiding this comment.
I kept appraisal lockfiles ignored because with the current Ruby version support bracket (2.6 ... 3.2) some dependencies like nokogiri cannot be locked due not having enough broad support (1, 2). Therefore CI test matrix fails for some of these incompatible combinations.
There was a problem hiding this comment.
I'm not sure we get much of the benefits without this, but I'm approving this PR because at least the primary gemfile will allow for a consistent experience for someone who pulls down the repo.
There was a problem hiding this comment.
@smudge indeed, starting with rubocop (lint job) not drifting due new cops available on each release (like the one I had to adjust myself here).
| @@ -34,7 +34,7 @@ def run! | |||
| attr_reader :jobs | |||
|
|
|||
| def emit_metric!(metric) | |||
| send("#{metric}_grouped").reverse_merge(default_results).each do |(priority, queue), value| | |||
| send(:"#{metric}_grouped").reverse_merge(default_results).each do |(priority, queue), value| | |||
There was a problem hiding this comment.
Address rubocop offense that cropped up.
| @@ -16,3 +16,6 @@ AllCops: | |||
|
|
|||
| Rails/EnvironmentVariableAccess: | |||
| Enabled: false | |||
|
|
|||
| RSpec/IndexedLet: | |||
There was a problem hiding this comment.
Rubocop started to lint this cop, which I disabled as spec subjects have this pattern.
Summary of changes:
Commit lockfile previously ignored (see https://bundler.io/guides/faq.html#using-gemfiles-inside-gems).
/task https://app.asana.com/0/0/1206244989881229/f