Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop EOL Ruby and Rails versions support #33

Closed
wants to merge 8 commits into from

Conversation

Irving-Betterment
Copy link
Contributor

@Irving-Betterment Irving-Betterment commented Dec 28, 2023

Summary of changes:

  • Drop end of life Ruby and Rails versions support.
  • Address rubocop offenses (detailed per commit).

/task https://app.asana.com/0/1206095065335149/1206250886010422/f

@Irving-Betterment Irving-Betterment force-pushed the icaro/ruby-rails-eol-support-drop branch from b16a2ed to 5e04c9c Compare December 28, 2023 21:22
@Irving-Betterment Irving-Betterment force-pushed the icaro/ruby-rails-eol-support-drop branch from 5e04c9c to ca827c1 Compare December 28, 2023 21:26
@Irving-Betterment Irving-Betterment marked this pull request as ready for review December 28, 2023 21:34
@smudge
Copy link
Member

smudge commented Jan 5, 2024

@Irving-Betterment For this gem, I think we'd like to keep supporting older versions for the time being. It's intended as a drop-in replacement for delayed_job, and keeping more relaxed version constraints reduces the amount of work it would take to migrate over. I think we should consider dropping version support only if maintaining the older version support becomes a particular pain point.

@Irving-Betterment
Copy link
Contributor Author

Closed as we want to keep supporting older versions for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants