Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for 426: Upgrade Required #12

Merged

Conversation

willlockwood
Copy link
Contributor

📰 Summary of changes

This adds support for the 426: Upgrade Required http status code, so that servers can indicate to clients using sturdy that they need to upgrade to some new version or protocol before accessing the resource. This adds a new case (.upgradeRequired(DioException error)) to NetworkResponse, and is therefore a breaking change.

🧪 Testing done

Updated existing tests to include coverage of the 426 status code mapping to the new upgradeRequired network response case.

@willlockwood willlockwood requested review from a team as code owners July 22, 2024 16:05
Copy link
Contributor

@btrautmann btrautmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain lgtm!

Just calling out explicitly that we're not adding this to the EventListener. I think that's a fine call, as I don't think we'd really do anything unique to that event other than log it (which I believe we already do via a logging Interceptor).

Copy link
Contributor

@btrautmann btrautmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform lgtm

@willlockwood willlockwood merged commit 296cc2c into Betterment:main Jul 22, 2024
3 checks passed
@willlockwood willlockwood deleted the lockwood/426-upgrade-required branch July 22, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants