feat: toString implementation on NetworkResponse #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willlockwood
approved these changes
Oct 30, 2024
azack
suggested changes
Oct 30, 2024
I have been bitten more than once by not having |
|
Closing this for now, will do this without equatable in a way that doesn't have unexpected behavior (see felangel/equatable#181, which I've been bitten by a couple times in the past). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📰 Summary of changes
This PR adds
package:equatableand makes use of it for simpletoStringimplementations on ourNetworkResponsemodels.This is necessary because we no longer use
package:freezedfor these. I considered removingfreezedentirely, but figured it was best to keep this PR isolated.🧪 Testing done
Added test to ensure the
toStringimplementation of at least one model remains present.