Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sturdy): Update to version 0.5.0 #52

Merged
merged 9 commits into from
Sep 18, 2024
Merged

Conversation

nhannah
Copy link
Collaborator

@nhannah nhannah commented Sep 18, 2024

📰 Summary of changes

  • Upgrade dependency and response types

@nhannah nhannah requested review from a team as code owners September 18, 2024 00:47
@nhannah nhannah requested a review from btrautmann September 18, 2024 00:47
willlockwood
willlockwood previously approved these changes Sep 18, 2024
Copy link
Contributor

@willlockwood willlockwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain lgtm
platform lgtm

@willlockwood
Copy link
Contributor

Looks like this needs to run our CI workflows with Dart 3.5, as Brandon did in the sturdy update as well: Betterment/sturdy_http#14

@nhannah
Copy link
Collaborator Author

nhannah commented Sep 18, 2024

@btrautmann I had to update 2 tests to no longer look for 500's but instead ServerError

@btrautmann
Copy link
Contributor

Before we merge this, lemme see if I can increase the pana score, 110 seems super low

Copy link
Contributor

@btrautmann btrautmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain lgtm
platform lgtm

@btrautmann btrautmann merged commit b3a96a6 into main Sep 18, 2024
4 checks passed
@btrautmann btrautmann deleted the neilhannah/sturdy-update branch September 18, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants