fix: update ab and vary types (#75)

Noticed some typing issues when going through `tsc` failures.
Betterment · Oct 16, 2024 · fbc6044 · fbc6044
1 parent 17f2107
commit fbc6044
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/abConfiguration.ts b/src/abConfiguration.ts
@@ -4,13 +4,13 @@ import SplitRegistry from './splitRegistry';
 
 export type ABConfigurationOptions = {
   splitName: string;
-  trueVariant: string | boolean;
+  trueVariant?: string;
   visitor: Visitor;
 };
 
 class ABConfiguration {
   private _splitName: string;
-  private _trueVariant: string | boolean;
+  private _trueVariant?: string;
   private _visitor: Visitor;
   private _splitRegistry: SplitRegistry;
 

diff --git a/src/visitor.ts b/src/visitor.ts
@@ -20,10 +20,9 @@ export type VaryOptions = {
 };
 
 export type AbOptions = {
-  callback: (assignment: boolean | string) => void;
+  callback: (assignment: boolean) => void;
   context: string;
-  trueVariant: boolean | string;
-  visitor: Visitor;
+  trueVariant?: string;
 };
 
 export type VisitorOptions = {