Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve pathing bug and add test coverage #61

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

jesseproudman
Copy link
Contributor

Fixes a bug around missing load paths in the prior release that wasn't covered in test coverage.

@@ -0,0 +1,31 @@
import TestTrack from './testTrack';
import ConfigParser from './configParser';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint check on this line needs to be disabled.

@jesseproudman jesseproudman changed the title Fix pathing bug and add test coverage fix: resolve pathing bug and add test coverage Sep 8, 2023
Copy link
Contributor

@zerodom30 zerodom30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platformLGTM

Copy link
Contributor

@zerodom30 zerodom30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainLGTM

@jesseproudman
Copy link
Contributor Author

I don't have merge rights so we'll need to do the build / release process again. :(

@zerodom30 zerodom30 merged commit 10f781d into Betterment:main Sep 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants