Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tina paper 2 #584

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Tina paper 2 #584

merged 4 commits into from
Oct 30, 2024

Conversation

tinatn29
Copy link
Contributor

add arxiv link and corrected previous errors (empty strings). We can merge this one and ignore the previous PR.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great. Please see my comments

db/citations.yml Outdated Show resolved Hide resolved
db/citations.yml Outdated Show resolved Hide resolved
db/citations.yml Outdated Show resolved Hide resolved
db/citations.yml Outdated Show resolved Hide resolved
@tinatn29
Copy link
Contributor Author

addressed all the comments

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment.

db/citations.yml Outdated
month: ''
nb: ''
note: submitted to npj Comput. Mater.
note: https://doi.org/10.48550/arXiv.2410.17467
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a URL it can go in the url field.

Here we want to put text so the reference will be correctly generated, so look in arXiv for how to reference this, and then write here the words. Bear in mind that since we wrote arxiv in the journal, it will reproduce this as the journal.

If you want to see how it will compile you can run regolith build publist --PEOPLE tnanarong --no-pdf It will build your publication list and you can go to _build/publist and find the tex file nad bib file and run latex to build your publlist and see what it looks like.

@@ -8570,7 +8570,7 @@ nanarong;npj24:
journal: arXiv
month: ''
nb: ''
note: https://doi.org/10.48550/arXiv.2410.17467
note: arXiv:2410.17467
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this what you meant by arxiv reference?

@sbillinge sbillinge merged commit 35328fd into Billingegroup:main Oct 30, 2024
0 of 2 checks passed
@sbillinge
Copy link
Contributor

super! thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants