Fix use of camlzip in byteweight #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivg
approved these changes
Jul 29, 2024
xavierleroy
reviewed
Jul 30, 2024
| List.iter entries ~f:(fun ({Zip.filename; extra; comment; mtime},data) -> | ||
| Zip.add_entry data zip filename | ||
| ~extra ~comment ~mtime) | ||
| List.iter entries ~f:(fun ({Zip.filename; comment; mtime},data) -> |
There was a problem hiding this comment.
If you write the pattern as follows, you'll remain compatible with CamlZip < 1.12 while not triggering warning 9:
fun ({Zip.filename; comment; mtime; _},data) ->
xavierleroy
reviewed
Jul 30, 2024
| @@ -283,7 +283,7 @@ | |||
| (depends | |||
| (bap-signatures (= :version)) | |||
| (bap-std (= :version)) | |||
| (camlzip (and (>= 1.0) (< 2.0))) | |||
| (camlzip (and (>= 1.12) (< 2.0))) | |||
There was a problem hiding this comment.
No need for >= 1.12 with the change I suggested.
|
Thanks @xavierleroy, I have another PR #1610 for consideration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1607, taking the suggestion by @xavierleroy