Update api readme #178
Update api readme #178
Conversation
api/Readme.md
Outdated
| @@ -40,19 +16,40 @@ curl -H "Content-Type: application/json" \ | |||
| http://localhost:8080/v2/auth/user/register | |||
| ``` | |||
|
|
|||
| The response should be just `null` and there should be no errors in the api container. | |||
| You should be able to authenticate using the email/password above at http://localhost:8080/docs (Authenticate button) | |||
There was a problem hiding this comment.
Authorize button, not Authenticate on my screen.
api/Readme.md
Outdated
| pwd | ||
|
|
||
| # the api used for testing runs on the host (not in docker) and is configures with the .env created above | ||
| pytest |
There was a problem hiding this comment.
poetry run pytest
this gives me ERROR - KeyError: 'DB_NAME'
There was a problem hiding this comment.
is this after following the steps in the whole block, including creating bia-integrator/api/.env ?
There was a problem hiding this comment.
What should happen is that if the api virtualenv is started, poetry loads the .env when I switch to the virtualenv. Except vscode switches into the virtualenv for every terminal, but the actual plain terminal doesn't. Tweaked the readme now, does poetry run pytest work?
|
|
||
| # the api used for testing runs on the host (not in docker) and is configures with the .env created above | ||
| pytest | ||
| ``` |
There was a problem hiding this comment.
Below worked fine until
docker build -t api-bia-integrator-api:latest .
Got the following error:
[+] Building 2.1s (10/13) docker:desktop-linux
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 1.01kB 0.0s
=> [internal] load metadata for docker.io/library/python:3.10.0 1.0s
=> [internal] load .dockerignore 0.0s
=> => transferring context: 2B 0.0s
=> [1/9] FROM docker.io/library/python:3.10.0@sha256:a1fba384d3aa879533a271ab5d73965fbd3385648f38835dacd07e519f1c7c3f 0.0s
=> [internal] load build context 1.0s
=> => transferring context: 628.46kB 1.0s
=> CACHED [2/9] RUN curl -sSL https://install.python-poetry.org | python3 - 0.0s
=> CACHED [3/9] WORKDIR /bia-integrator 0.0s
=> [4/9] ADD api/poetry.lock* api/poetry.lock 0.0s
=> ERROR [5/9] ADD api/pyproject.toml api/pyproject.toml 0.0s
=> ERROR [6/9] ADD bia-shared-datamodels bia-shared-datamodels 0.0s
[5/9] ADD api/pyproject.toml api/pyproject.toml:
[6/9] ADD bia-shared-datamodels bia-shared-datamodels:
Dockerfile:17
15 |
16 | # This needed to be added because it's a poetry dep
17 | >>> ADD bia-shared-datamodels bia-shared-datamodels
18 |
19 | WORKDIR /bia-integrator/api
ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref 4a7e193a-3bcc-4f93-b2be-9c4f5ccebe46::0hkxb8pimlv2bx4oy73ozdx1h: "/bia-shared-datamodels": not found
There was a problem hiding this comment.
was this run in bia-integrator/api? Adding that in the readme now
There was a problem hiding this comment.
nvm, I thought that part was still working so left it in but it's not because we switched context root. Fixing now
|
Fixed comments (I think), can you retry the parts that weren't working previously please? |
https://app.clickup.com/t/8695gpnmh