Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better api logs #276

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Better api logs #276

merged 3 commits into from
Jan 8, 2025

Conversation

liviuba
Copy link
Contributor

@liviuba liviuba commented Jan 6, 2025

https://app.clickup.com/t/86979zne5

Everything for all requests in a single log format, might need to reconsider if logs get too big

LE: extra fields added should help tell if a slow request should be slow because it's just big, or if there is an issue somewhere

This reverts commit 30b1594.
Copy link
Contributor

@kbab kbab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbab kbab merged commit 5e111dc into main Jan 8, 2025
24 of 25 checks passed
@kbab kbab deleted the better_logs branch January 8, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants