Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High-rate wwt bugfixes (accumulation, infinite loop) #200

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

sarangbhagwat
Copy link
Member

For issue #199. @yalinli2, let me know if these fixes are good / need any changes, thanks!

Copy link
Member

@yalinli2 yalinli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I didn't really run the codes, but if the tests can pass then it should be good! Let me know if you notice significant changes in results. Thanks for noting/fixing this issue!

@sarangbhagwat
Copy link
Member Author

Thanks, @yalinli2 ! I didn't see drastic changes compared to the results that were in the docstring before other than in the PolishingFilter vent (as intended). I'll keep an eye out for any suspicious-looking results!

@sarangbhagwat sarangbhagwat merged commit 94c7374 into master Apr 17, 2024
1 of 2 checks passed
@sarangbhagwat sarangbhagwat deleted the highrate_wwt_bugfix branch April 17, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants