Add parameter N_reactors to StirredTankReactor and enable passing RGBn tuples as arguments for color_wheel in plot_spearman_2d #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests, these are minor changes enabling the following:
(i) View number of reactors for a
StirredTankReactorobject using a new attribute,N_reactors;(ii) Pass iterable of RGBn tuples rather than iterable of colors for the color_wheel argument in
plot_spearman_2d.I have updated the doctest for
StirredTankReactorto cover (i); if testing is needed for (ii), feel free to add any, thanks!