-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(apps/whale-api): update poolpairs to ignore token symbols with BURN
#2085
base: main
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit 60a5a95 and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2085 +/- ##
==========================================
+ Coverage 83.78% 91.31% +7.53%
==========================================
Files 363 359 -4
Lines 10981 10858 -123
Branches 1433 1416 -17
==========================================
+ Hits 9200 9915 +715
+ Misses 1680 902 -778
+ Partials 101 41 -60
... and 124 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I am thinking about this again, should we consider filtering out the poolpair that has And on product side we are manually filtering again For backward compatibility, maybe we should by default return all pair, and accept a new param that will filter out Update from Update (23/03/2023 16:23): we will not be checking |
BURN
BURN
BURN
BURN
What this PR does / why we need it:
Updated
poolpair.controller.ts
to ignore symbols with
BURN
egBURN
,BURN2
and not onlyBURN
and
poolpair.prices.services.ts
to include symbols withBURN
as untradeableTokenWhich issue(s) does this PR fixes?:
Fixes #
Additional comments?:
This PR is to be put on hold as we are exploring on showing
BURN
without implying that they are tradable