frontend: change transaction info for send-to-self

[thisconnect]

Until now a send-to-self transaction looked more like an outgoing transaction with the amount sent.

Changed to only show the fee paid as outgoing and the amount of coin as conversion amount.

[thisconnect]

I slightly prefer if we could just pass all that data anyways.

[thisconnect]

interestingly TypeScript already expected that there is fee, also it thinks there is gas and nonce. I am planing to open another PR to fix the types and make gas/nonce only be in /transaction?id= endpoint and optional.

bitbox-wallet-app/frontends/web/src/api/account.ts

Lines 247 to 250 in 12df2de

	fee: IAmount;
	feeRatePerKb: IAmount;
	gas: number;
	nonce: number | null;

[thisconnect]

rebased

[thisconnect]

[shonsirsha]

FE tested LGTM:

[Tomasvrba]

@thisconnect nack from me, personally showing the fee as the bigger number (and therefore the main number always being negative) seems really counterintuitive, I would switch them around, the send amount with the "send to self" icon as the main number and the fee as the smaller number below (ideally with the label "fee")

Always having these long string fee amounts as the main tx amount doesn't look very good:

[thisconnect]

personally showing the fee as the bigger number (and therefore the main number always being negative) seems really counterintuitive, I would switch them around, the send amount with the "send to self" icon as the main number and the fee as the smaller number below (ideally with the label "fee")

Thanks for the input, the main reason to show the fee as negative "bigger number" is so it shows what was spent for this transaction.

Always having these long string fee amounts as the main tx amount doesn't look very good

In ETH this indeed shows very long numbers due to 18 digits.

I will discuss both points internally...

[thisconnect]

@Tomasvrba did you test with tokens as well?

[Tomasvrba]

@Tomasvrba did you test with tokens as well?

Yes, same issue from my perspective, since it's a token "account" I would expect the main tx number be the token transferred in the tx, not the eth-denominated fee

[thisconnect]

rebased

[thisconnect]

showing the fee as the bigger number (and therefore the main number always being negative) seems really counterintuitive, I would switch them around, the send amount with the "send to self" icon as the main number and the fee as the smaller number below (ideally with the label "fee")

As discussed internally:

For send-to-self transactions we keep showing the fee as the bigger number so that the user see what they spent to do so.

In ERC20 tokens the fee is in ETH that is how Ethereum works, but

…there seems to be no good use-case to do send-to-self on account based coins/tokens. If you find out how contract interaction would look like in the app where the user initiates some kind of withdrawal which results in a deposit to the user's address please let me know.

[thisconnect]

rebased, cc @Beerosagos PTAL at the backend change.

[Beerosagos]

This works, but it would be better as Fee: feeString, inside the txInfoJSON object creation above

[thisconnect]

done

[Beerosagos]

backend LGTM

[thisconnect]

rebased