Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

139 add error handling to DHT #241

Merged
merged 2 commits into from
Nov 27, 2024
Merged

139 add error handling to DHT #241

merged 2 commits into from
Nov 27, 2024

Conversation

zupzup
Copy link
Collaborator

@zupzup zupzup commented Nov 27, 2024

Some more prep work for the DHT part of #139, adding error handling to the dht client and dht setup and a few cleanup and refactoring steps in those parts.

@zupzup zupzup self-assigned this Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 13.20755% with 322 lines in your changes missing coverage. Please review.

Project coverage is 39.48%. Comparing base (02df6f8) to head (287d910).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/dht/client.rs 0.00% 195 Missing ⚠️
src/dht/mod.rs 0.00% 55 Missing ⚠️
src/util/terminal.rs 0.00% 28 Missing ⚠️
src/persistence/bill.rs 0.00% 13 Missing ⚠️
src/service/bill_service.rs 0.00% 12 Missing ⚠️
src/main.rs 0.00% 8 Missing ⚠️
src/service/company_service.rs 89.09% 6 Missing ⚠️
src/service/contact_service.rs 0.00% 2 Missing ⚠️
src/service/identity_service.rs 0.00% 2 Missing ⚠️
src/web/handlers/bill.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   39.14%   39.48%   +0.34%     
==========================================
  Files          54       54              
  Lines       10235    10232       -3     
==========================================
+ Hits         4006     4040      +34     
+ Misses       6229     6192      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tompro tompro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

src/dht/mod.rs Show resolved Hide resolved
@zupzup zupzup merged commit dfe4d95 into master Nov 27, 2024
6 of 7 checks passed
@zupzup zupzup deleted the 139-company-identity-dht branch November 27, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants