-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Trinket Compare #113
base: develop
Are you sure you want to change the base?
Adds Trinket Compare #113
Conversation
This looks great! Let me add some information:
Midterm:
Longterm:
|
…tend into develop
…on, handles item levels and fight types correctly.
Finally picked this back up! I reworked this so that it does not constantly self-crawl the site. Given that we currently receive all item data for any one spec, to generate these charts, we only need to hit each spec once and cache the result in localstorage (updated every 30 minutes). Additionally, I extracted several functions from As far as I can tell, these changes don't impact existing functionality, though I have not ventured into accounts and custom charts. |
Sounds great! I'll need some time to review it. I'm currently busy preparing my own chart implementations and that's occupying my attention. I'll hopefully get back to you soon on this. 👍 |
…on, handles item levels and fight types correctly.
…tend into develop
merge upstream
Needed a good way to see a trinket's impact across multiple specs.
Adds:
Outstanding todos:
MVP:
- Hook into db instead of fetching everything like a goblin- Need to add trinket-specific queries instead of needing to get ALL trinkets for ALL specs 😒- Server-side data handlingMidterm:
Just picked Rogue.is now priestLongterm: